Issue 4321003: GTK: Allow file I/O in file dialog functions functions on the UI thread....

Issue 4321003: GTK: Allow file I/O in file dialog functions functions on the UI thread.... (Closed)

Created:
10 years, 1 month ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org, Randy Smith (Not in Mondays)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Allow file I/O in file dialog functions functions on the UI thread. BUG=61611 TEST=Linux file dialogs don't trigger AssertIOAllowed DCHECKs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64859

Patch Set 1 : '' #

Total comments: 6

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -54 lines)			Patch
	M	chrome/browser/gtk/dialogs_gtk.cc	View	1	6 chunks	+55 lines, -54 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

LGTM http://codereview.chromium.org/4321003/diff/3001/4001 File chrome/browser/gtk/dialogs_gtk.cc (right): http://codereview.chromium.org/4321003/diff/3001/4001#newcode17 chrome/browser/gtk/dialogs_gtk.cc:17: #include "base/utf_string_conversions.h" alphabet please http://codereview.chromium.org/4321003/diff/3001/4001#newcode109 chrome/browser/gtk/dialogs_gtk.cc:109: bool CallDirectoryExistsOnUIThreadForFileDialogs(const ...

10 years, 1 month ago (2010-11-02 22:37:02 UTC) #2

Lei Zhang

10 years, 1 month ago (2010-11-02 22:40:38 UTC) #3

http://codereview.chromium.org/4321003/diff/3001/4001
File chrome/browser/gtk/dialogs_gtk.cc (right):

http://codereview.chromium.org/4321003/diff/3001/4001#newcode17
chrome/browser/gtk/dialogs_gtk.cc:17: #include "base/utf_string_conversions.h"
On 2010/11/02 22:37:02, Evan Stade wrote:
> alphabet please

Done.

http://codereview.chromium.org/4321003/diff/3001/4001#newcode109
chrome/browser/gtk/dialogs_gtk.cc:109: bool
CallDirectoryExistsOnUIThreadForFileDialogs(const FilePath& path);
On 2010/11/02 22:37:02, Evan Stade wrote:
> name of this function is a bit crazy. How about just
> CheckDirectoryExistsFromUIThread?

Done.

http://codereview.chromium.org/4321003/diff/3001/4001#newcode346
chrome/browser/gtk/dialogs_gtk.cc:346: base::ThreadRestrictions::ScopedAllowIO
allow_io;
On 2010/11/02 22:37:02, Evan Stade wrote:
> so this allows disk IO eh? Confusing that it's a different meaning of IO from
> the IO in "IO thread". 
> 
> (I didn't really follow the thread about all this stuff so I'm sure this has
> been discussed already.)

Yes, this is for file I/O, see base/thread_restrictions.h

Expand Messages | Collapse Messages