Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 432017: gclient: handle case for upstream has rebased (Closed)

Created:
11 years ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel, djmm
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

gclient: handle case for upstream has rebased gclient sync will potentially fail if the upstream git tree has been rebased. This CL fixes this by using rebase --onto to only rebase our local changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33011

Patch Set 1 #

Patch Set 2 : Fix bug. #

Patch Set 3 : Fixed some corner cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M gclient_scm.py View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
11 years ago (2009-11-24 23:20:35 UTC) #1
M-A Ruel
11 years ago (2009-11-24 23:52:17 UTC) #2
totally rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698