Chromium Code Reviews

Issue 4320004: Extract essential type declarations into separate file. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)
CC:
v8-dev
Visibility:
Public.

Description

Extract essential type declarations into separate file.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Stats (+56 lines, -19 lines)
M include/v8.h View 3 chunks +3 lines, -19 lines 0 comments
A include/v8stdint.h View 1 chunk +53 lines, -0 lines 0 comments

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
10 years, 1 month ago (2010-11-03 14:01:32 UTC) #1
Kevin Millikin (Chromium)
Drive by, only because I'm passionate about the #else comment. http://codereview.chromium.org/4320004/diff/1/3 File include/v8stdint.h (right): http://codereview.chromium.org/4320004/diff/1/3#newcode1 ...
10 years, 1 month ago (2010-11-03 14:15:08 UTC) #2
Mads Ager (chromium)
10 years, 1 month ago (2010-11-03 14:24:27 UTC) #3
What Kevin said. Once that is addressed LGTM.

Powered by Google App Engine