Issue 4318005: Made OSMesa shared library position independent on linux....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4318005: Made OSMesa shared library position independent on linux.... (Closed)

Created:
10 years, 1 month ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Made OSMesa shared library position independent on linux. This is an attempt to fix this valgrind error: http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20(valgrind)(2)/builds/210/steps/memory%20test:%20ui_1/logs/stdio It appears mmap might have been trying to map libosmesa.so to a fixed address. TEST=try BUG=61601 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64941

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	third_party/mesa/mesa.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	tools/valgrind/gtest_exclude/ui_tests.gtest.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Ken Russell (switch to Gerrit)

10 years, 1 month ago (2010-11-03 18:26:24 UTC) #2

LGTM, but please update the CL to say BUG=61601 .