Issue 43137: Add a TabController class to manage a TabView (with corresponding xib). Rewri...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43137: Add a TabController class to manage a TabView (with corresponding xib). Rewri... (Closed)

Created:
11 years, 9 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a TabController class to manage a TabView (with corresponding xib). Rewrite strip controller to create and manage TabControllers instead of NSButtons. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11541

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+649 lines, -44 lines)			Patch
A	chrome/app/nibs/en.lproj/TabView.xib	View		1 chunk	+426 lines, -0 lines	0 comments	Download
A	chrome/app/theme/nav.pdf	View		Binary file		0 comments	Download
A	chrome/browser/cocoa/tab_controller.h	View	1 2	1 chunk	+44 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/tab_controller.mm	View		1 chunk	+51 lines, -0 lines	2 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.h	View	1 2	2 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.mm	View	1	14 chunks	+41 lines, -36 lines	0 comments	Download
A	chrome/browser/cocoa/tab_view.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/tab_view.mm	View		1 chunk	+49 lines, -0 lines	2 comments	Download
M	chrome/chrome.gyp	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm w/ some followup Qs http://codereview.chromium.org/43137/diff/11/15 File chrome/browser/cocoa/tab_controller.mm (right): http://codereview.chromium.org/43137/diff/11/15#newcode42 Line 42: selected_ = selected; ...

11 years, 9 months ago (2009-03-12 15:56:42 UTC) #2

pink (ping after 24hrs)

11 years, 9 months ago (2009-03-12 16:04:47 UTC) #3

http://codereview.chromium.org/43137/diff/11/15
File chrome/browser/cocoa/tab_controller.mm (right):

http://codereview.chromium.org/43137/diff/11/15#newcode42
Line 42: selected_ = selected;
On 2009/03/12 15:56:42, TVL wrote:
> see if the state changed to avoid updates if it's the current value?

Done.

Expand Messages | Collapse Messages