Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 43130: Fix the handling of line offset when getting the source line from a ScriptMirror (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

During the refactoring in r1461 and adding of script ids in r1468 the propagation of a boolean flag was missing. This caused the line numbers retreived through ScriptMirror objects to ignore the resource line offset information in the script. Added an explicit false parameter where the parameter was previously left out. Added a test case for this. Committed: http://code.google.com/p/v8/source/detail?r=1499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M src/debug-delay.js View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mirror-delay.js View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-12 13:54:47 UTC) #1
Mads Ager (chromium)
11 years, 9 months ago (2009-03-12 13:56:09 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698