Fixed activation process....

Fixed activation process.

BUG=chromium-os:8400
TEST=make sure cellular device can be activated from UI


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64804

[zel, 2010-11-02 18:42:45]

This CL includes crash fix and final set of changes for cellular activation
process.

[Charlie Lee, 2010-11-02 18:56:51]

LGTM with nits.

http://codereview.chromium.org/4311002/diff/3001/4001
File chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc (right):

http://codereview.chromium.org/4311002/diff/3001/4001#newcode434
chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc:434: if
(LowerCaseEqualsASCII(status, "ok")) {
duh! I hope it didn't take you too long to catch this.

http://codereview.chromium.org/4311002/diff/3001/4001#newcode575
chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc:575: return "ACTIVATING";
Maybe change this to RECONNECTING to be consistent.

http://codereview.chromium.org/4311002/diff/3001/4001#newcode712
chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc:712: 
remove extra new line

[zel, 2010-11-02 19:16:34]

http://codereview.chromium.org/4311002/diff/3001/4001
File chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc (right):

http://codereview.chromium.org/4311002/diff/3001/4001#newcode575
chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc:575: return "ACTIVATING";
On 2010/11/02 18:56:51, Charlie Lee wrote:
> Maybe change this to RECONNECTING to be consistent.

Done.

http://codereview.chromium.org/4311002/diff/3001/4001#newcode712
chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc:712: 
On 2010/11/02 18:56:51, Charlie Lee wrote:
> remove extra new line

i want two lines here since the method above has some single empty lines within

[Eric Shienbrood, 2010-11-02 19:24:52]

LGTM