Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: build/temp_gyp/v8.gyp

Issue 43108: Get rid of now unnecessary SCons-isms for gyp on Linux (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/temp_gyp/v8.gyp
===================================================================
--- build/temp_gyp/v8.gyp (revision 11450)
+++ build/temp_gyp/v8.gyp (working copy)
@@ -265,10 +265,6 @@
'<(SHARED_INTERMEDIATE_DIR)/v8/libraries-empty.cc',
],
'action': ['python', '../../v8/tools/js2c.py', '<@(_outputs)', 'CORE', '<@(library_files)'],
- # TODO(sgk): figure out how to get gyp and SCons to play nice here.
- 'conditions': [
- ['OS=="linux"', {'action=': ['python', '${SOURCES[0]}', '${TARGETS}', 'CORE', '${SOURCES[1:]}'],}],
- ],
},
],
},
@@ -295,10 +291,6 @@
'<(SHARED_INTERMEDIATE_DIR)/v8/d8-js-empty.cc',
],
'action': ['python', '../../v8/tools/js2c.py', '<@(_outputs)', 'D8', '<@(library_files)'],
- # TODO(sgk): figure out how to get gyp and SCons to play nice here.
- 'conditions': [
- ['OS=="linux"', {'action=': ['python', '${SOURCES[0]}', '${TARGETS}', 'D8', '${SOURCES[1:]}'],}],
- ],
},
],
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698