Issue 431041: Implement method stubs for OpenMAX IL instead of relying on -lOmxCore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 431041: Implement method stubs for OpenMAX IL instead of relying on -lOmxCore. (Closed)

Created:
11 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
awong, Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Implement method stubs for OpenMAX IL instead of relying on -lOmxCore. You can switch to using -lOmxCore by setting the gyp variable use_system_openmax=1. Also fixed type-punning warnings in omx_video_decoder.cc BUG=28663 TEST=building omx_test should have no linker errors Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33012

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -49 lines)			Patch
M	build/all.gyp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	media/media.gyp	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	media/omx/omx_test.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
D	media/omx/omx_test.gyp	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	media/omx/omx_video_decoder.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
A	third_party/openmax/omx_stub.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	third_party/openmax/openmax.gyp	View	2 chunks	+43 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

Same as before, but now includes type-punning fix to omx_video_decoder.cc

11 years, 1 month ago (2009-11-24 23:59:32 UTC) #1

LGTM

Expand Messages | Collapse Messages