Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 43101: Switching to gyp generated vcprojs for some components. (Closed)

Created:
11 years, 9 months ago by bradn
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Switching to gyp generated vcprojs for some components. Includes propset changes: Property changes on: C:\clients\chrome6\src\skia ___________________________________________________________________ Modified: svn:ignore - skia.xcodeproj + skia.xcodeproj skia.sln Property changes on: C:\clients\chrome6\src\third_party\zlib ___________________________________________________________________ Modified: svn:ignore - zlib.xcodeproj + zlib.xcodeproj zlib.sln Property changes on: C:\clients\chrome6\src\third_party\libpng ___________________________________________________________________ Modified: svn:ignore - libpng.xcodeproj + libpng.xcodeproj libpng.sln Property changes on: C:\clients\chrome6\src\third_party\libjpeg ___________________________________________________________________ Modified: svn:ignore - libjpeg.xcodeproj + libjpeg.xcodeproj libjpeg.sln Property changes on: C:\clients\chrome6\src\build ___________________________________________________________________ Modified: svn:ignore - all.xcodeproj + all.xcodeproj all.sln All.vcproj Property changes on: C:\clients\chrome6\src\base ___________________________________________________________________ Modified: svn:ignore - base.xcodeproj + base.xcodeproj base.vcproj base_gfx.vcproj base_unittests.vcproj debug_message.vcproj Property changes on: C:\clients\chrome6\src\testing ___________________________________________________________________ Modified: svn:ignore - gtest gtest.xcodeproj + gtest gtest.xcodeproj gtest.sln Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11512

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2432 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
D base/base.sln View 1 chunk +0 lines, -154 lines 0 comments Download
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D skia/skia.vcproj View 1 chunk +0 lines, -1467 lines 0 comments Download
D testing/gtest.vcproj View 1 2 1 chunk +0 lines, -247 lines 0 comments Download
D third_party/libjpeg/libjpeg.vcproj View 1 chunk +0 lines, -265 lines 0 comments Download
D third_party/libpng/libpng.vcproj View 1 chunk +0 lines, -129 lines 0 comments Download
D third_party/zlib/zlib.vcproj View 1 chunk +0 lines, -169 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bradn
I'd like to try to land this when it will be non-disruptive. The gyp file ...
11 years, 9 months ago (2009-03-11 22:09:08 UTC) #1
Mark Mentovai
You will need to set svn:ignore for all of the files that are going to ...
11 years, 9 months ago (2009-03-11 22:29:41 UTC) #2
bradn
http://codereview.chromium.org/43101/diff/1/8 File testing/gtest.vcproj (right): http://codereview.chromium.org/43101/diff/1/8#newcode2 Line 2: <VisualStudioProject Keyword="Win32Proj" Name="gtest" ProjectGUID="{BFE8E2A7-3B3B-43B0-A994-3058B852DB8B}" ProjectType="Visual C++" RootNamespace="gtest" Version="8.00"> ...
11 years, 9 months ago (2009-03-11 23:54:10 UTC) #3
Nicolas Sylvain
11 years, 9 months ago (2009-03-12 00:33:12 UTC) #4
LGTM, good luck

Powered by Google App Engine
This is Rietveld 408576698