Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: chrome/browser/session_history_uitest.cc

Issue 431008: Make SystemMonitor not a Singleton and move it out of base (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: fix ChromeFrame build Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/profile_manager.cc ('k') | chrome/browser/tabs/tab_strip_model_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "app/l10n_util.h" 5 #include "app/l10n_util.h"
6 #include "base/file_path.h" 6 #include "base/file_path.h"
7 #include "base/platform_thread.h" 7 #include "base/platform_thread.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "chrome/common/url_constants.h" 9 #include "chrome/common/url_constants.h"
10 #include "chrome/test/automation/tab_proxy.h" 10 #include "chrome/test/automation/tab_proxy.h"
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 485
486 // This test is flaky. It looks like the server does not start fast enough, 486 // This test is flaky. It looks like the server does not start fast enough,
487 // and the navigation fails (with 404). See http://crbug.com/8444. 487 // and the navigation fails (with 404). See http://crbug.com/8444.
488 TEST_F(SessionHistoryTest, FLAKY_LocationReplace) { 488 TEST_F(SessionHistoryTest, FLAKY_LocationReplace) {
489 // Test that using location.replace doesn't leave the title of the old page 489 // Test that using location.replace doesn't leave the title of the old page
490 // visible. 490 // visible.
491 scoped_refptr<HTTPTestServer> server = 491 scoped_refptr<HTTPTestServer> server =
492 HTTPTestServer::CreateServer(kDocRoot, NULL); 492 HTTPTestServer::CreateServer(kDocRoot, NULL);
493 ASSERT_TRUE(NULL != server.get()); 493 ASSERT_TRUE(NULL != server.get());
494 494
495 ASSERT_TRUE(tab_->NavigateToURL(server->TestServerPage( 495 ASSERT_TRUE(tab_->NavigateToURLBlockUntilNavigationsComplete(
Mike Belshe 2009/11/26 17:03:12 Is this an accidental file inclusion to this CL?
496 "files/session_history/replace.html?no-title.html"))); 496 server->TestServerPage(
497 "files/session_history/replace.html?no-title.html"), 2));
497 EXPECT_EQ(L"", GetTabTitle()); 498 EXPECT_EQ(L"", GetTabTitle());
498 } 499 }
499 500
500 // This test is flaky. See bug 22111. 501 // This test is flaky. See bug 22111.
501 TEST_F(SessionHistoryTest, FLAKY_HistorySearchXSS) { 502 TEST_F(SessionHistoryTest, FLAKY_HistorySearchXSS) {
502 // about:blank should be loaded first. 503 // about:blank should be loaded first.
503 ASSERT_FALSE(tab_->GoBack()); 504 ASSERT_FALSE(tab_->GoBack());
504 EXPECT_EQ(L"", GetTabTitle()); 505 EXPECT_EQ(L"", GetTabTitle());
505 506
506 GURL url(std::string(chrome::kChromeUIHistoryURL) + 507 GURL url(std::string(chrome::kChromeUIHistoryURL) +
(...skipping 18 matching lines...) Expand all
525 526
526 ASSERT_TRUE(tab_->NavigateToURL(GURL( 527 ASSERT_TRUE(tab_->NavigateToURL(GURL(
527 "javascript:void(frames[0].navigate())"))); 528 "javascript:void(frames[0].navigate())")));
528 EXPECT_EQ(L"foo", GetTabTitle()); 529 EXPECT_EQ(L"foo", GetTabTitle());
529 530
530 ASSERT_TRUE(tab_->GoBack()); 531 ASSERT_TRUE(tab_->GoBack());
531 EXPECT_EQ(L"Default Title", GetTabTitle()); 532 EXPECT_EQ(L"Default Title", GetTabTitle());
532 } 533 }
533 534
534 } // namespace 535 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/profile_manager.cc ('k') | chrome/browser/tabs/tab_strip_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698