DOMUI Cert Manager: merge email certs into other certs tab.

DOMUI Cert Manager: merge email certs into other certs tab.

BUG=19991
TEST=cert manager no longer has a "people" tab, any certs that were there are now in "other" tab.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64866

[wtc, 2010-11-02 23:50:14]

LGTM.

http://codereview.chromium.org/4310004/diff/1/3
File chrome/browser/certificate_manager_model.cc (left):

http://codereview.chromium.org/4310004/diff/1/3#oldcode75
chrome/browser/certificate_manager_model.cc:75:
x509_certificate_model::GetEmailAddress(cert.os_cert_handle()));
Can we remove the x509_certificate_model::GetEmailAddress() function now?

http://codereview.chromium.org/4310004/diff/1/10
File net/base/cert_type.h (right):

http://codereview.chromium.org/4310004/diff/1/10#newcode14
net/base/cert_type.h:14: // email address or Certificate Authority Basic
Constraint, and assigned trust
This comment may need to be updated to remove the reference to "email address".

http://codereview.chromium.org/4310004/diff/1/11
File net/third_party/mozilla_security_manager/nsNSSCertificateDB.cpp (right):

http://codereview.chromium.org/4310004/diff/1/11#newcode225
net/third_party/mozilla_security_manager/nsNSSCertificateDB.cpp:225: // ignore
user certs
This comment needs to be updated.

[mattm, 2010-11-03 00:14:01]

http://codereview.chromium.org/4310004/diff/1/3
File chrome/browser/certificate_manager_model.cc (left):

http://codereview.chromium.org/4310004/diff/1/3#oldcode75
chrome/browser/certificate_manager_model.cc:75:
x509_certificate_model::GetEmailAddress(cert.os_cert_handle()));
On 2010/11/02 23:50:14, wtc wrote:
> Can we remove the x509_certificate_model::GetEmailAddress() function now?

It's also used by the SSLClientCertificateSelector

http://codereview.chromium.org/4310004/diff/1/10
File net/base/cert_type.h (right):

http://codereview.chromium.org/4310004/diff/1/10#newcode14
net/base/cert_type.h:14: // email address or Certificate Authority Basic
Constraint, and assigned trust
On 2010/11/02 23:50:14, wtc wrote:
> This comment may need to be updated to remove the reference to "email
address".

Done.

http://codereview.chromium.org/4310004/diff/1/11
File net/third_party/mozilla_security_manager/nsNSSCertificateDB.cpp (right):

http://codereview.chromium.org/4310004/diff/1/11#newcode225
net/third_party/mozilla_security_manager/nsNSSCertificateDB.cpp:225: // ignore
user certs
On 2010/11/02 23:50:14, wtc wrote:
> This comment needs to be updated.

Done.

[wtc, 2010-11-03 01:25:59]

LGTM.

http://codereview.chromium.org/4310004/diff/5001/6009
File net/base/cert_type.h (right):

http://codereview.chromium.org/4310004/diff/5001/6009#newcode15
net/base/cert_type.h:15: // example, a cert with no basic constraints or trust,
would be classified as
Nit: remove the second comma (after "trust").