Issue 4310001: Make CheckLicense() to not trigger on empty files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4310001: Make CheckLicense() to not trigger on empty files. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, jrbarnette

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Make CheckLicense() to not trigger on empty files. This is especially annoying on empty __init__.py files. TEST=new unit test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64904

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	tests/presubmit_unittest.py	View		3 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm do you plan to use allow_empty_files somewhere or why did you add it?

10 years, 1 month ago (2010-11-02 18:54:09 UTC) #2

M-A Ruel

10 years, 1 month ago (2010-11-03 13:13:34 UTC) #3

On 2010/11/02 18:54:09, jochen wrote:
> lgtm
> 
> do you plan to use allow_empty_files somewhere or why did you add it?

No, it's just in case someone wants to disable that new functionality.

Expand Messages | Collapse Messages