Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 431: Fixes the following bugs reported with the Silverlight plugin:-... (Closed)

Created:
12 years, 3 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixes the following bugs reported with the Silverlight plugin:- http://code.google.com/p/chromium/issues/detail?id=248 http://code.google.com/p/chromium/issues/detail?id=666 The basic issue here was that the plugin would not paint correctly. The URLs mentioned in this bug load windowed silverlight plugin instances, which invoke the NPN_InvalidateRect API to paint. We send over the rects to the renderer, however these don't generate paints as the plugin is windowed. A peek at Safari's webkit implementation revealed that they merely invoke the InvalidateRect windows API in this context. The fix is to emulate this behavior. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M webkit/glue/plugins/plugin_host.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
12 years, 3 months ago (2008-09-04 04:32:37 UTC) #1
jam
12 years, 3 months ago (2008-09-04 19:29:23 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698