Issue 43094: Prevent system WebCore.framework from not working due to collisions with...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43094: Prevent system WebCore.framework from not working due to collisions with... (Closed)

Created:
11 years, 9 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Prevent system WebCore.framework from not working due to collisions with Objective-C names in our libwebcore.a by giving our Objective-C WebCore classes alternate names. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11631

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -2 lines)			Patch
	M	webkit/config.h.in	View	1	1 chunk	+31 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

lgtm w/ fix. http://codereview.chromium.org/43094/diff/1/2 File webkit/config.h.in (right): http://codereview.chromium.org/43094/diff/1/2#newcode165 Line 165: #endif this is !PLATFORM(DARWIN) http://codereview.chromium.org/43094/diff/1/2#newcode169 ...

11 years, 9 months ago (2009-03-11 19:56:07 UTC) #2

With TVL's comments, lgtm

Expand Messages | Collapse Messages