Adds an --incognito switch that can be used to launch Chrome in Incognito mod...

Adds an --incognito switch that can be used to launch Chrome in Incognito mode. You can combine this with --app= to launch an app in Chrome that has no effect on the user's profile.

Note that this is not the same thing as launching chrome.exe --user-data-dir=/dev/null, which would give you an completely empty profile instead of loading the user's profile as read-only.

BUG=1790, 2012

[M-A Ruel, 2008-09-26 20:53:38]

http://codereview.chromium.org/4309/diff/1/2
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/4309/diff/1/2#newcode673
Line 673: profile = profile->GetOffTheRecordProfile();
Memory leak?

[yarin, 2008-09-26 21:02:30]

On 2008/09/26 20:53:38, M-A wrote:
> http://codereview.chromium.org/4309/diff/1/2
> File chrome/browser/browser_init.cc (right):
> 
> http://codereview.chromium.org/4309/diff/1/2#newcode673
> Line 673: profile = profile->GetOffTheRecordProfile();
> Memory leak?

- ProfileImpl::GetOffTheRecordProfile() keeps track of the pointer it returns by
using a private scoped_ptr member variable. 
- OffTheRecordProfileImpl::GetOffTheRecordProfile() just does "return this".

So: No memory leak as far as I can say :)

[Peter Kasting, 2008-09-26 21:24:19]

Please ensure this is OK'd by the UI team before commit.  beng and others had
reservations about this last time I asked them.

http://codereview.chromium.org/4309/diff/1/2
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/4309/diff/1/2#newcode672
Line 672: if (parsed_command_line.HasSwitch(switches::kIncognito)) {
Nit: No braces here

[Patrick Johnson, 2008-09-26 23:13:54]

http://codereview.chromium.org/4309/diff/7/206
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/4309/diff/7/206#newcode671
Line 671: // Continue with the off-the-record profile from here on if
--incognito was specified
Nit: More than 80 characters.

[Nabil Al-Kourainy, 2008-10-13 18:49:14]

On 2008/09/26 23:13:54, Patrick Johnson wrote:
> http://codereview.chromium.org/4309/diff/7/206
> File chrome/browser/browser_init.cc (right):
> 
> http://codereview.chromium.org/4309/diff/7/206#newcode671
> Line 671: // Continue with the off-the-record profile from here on if
> --incognito was specified
> Nit: More than 80 characters.

Ok, so after you download the patch, how do you implement it? I'm a complete
noob with the coding described here. A tutorial would be greatly appreciated.
Thanks for the assistance.

-NKA

[Nabil Al-Kourainy, 2008-10-13 18:56:31]

On 2008/10/13 18:49:14, nabilalk wrote:
> On 2008/09/26 23:13:54, Patrick Johnson wrote:
> > http://codereview.chromium.org/4309/diff/7/206
> > File chrome/browser/browser_init.cc (right):
> > 
> > http://codereview.chromium.org/4309/diff/7/206#newcode671
> > Line 671: // Continue with the off-the-record profile from here on if
> > --incognito was specified
> > Nit: More than 80 characters.
> 
> Ok, so after you download the patch, how do you implement it? I'm a complete
> noob with the coding described here. A tutorial would be greatly appreciated.
> Thanks for the assistance.
> 
> -NKA

I have located the Chrome profile folder.  Do I edit the preferences with a
text-editor and copy & paste the code in there?

[Nabil Al-Kourainy, 2008-10-13 19:05:14]

Great work on the patch.  How do I implement it? Thanks.

[Patrick Johnson, 2008-10-13 19:08:08]

On 2008/10/13 19:05:14, Nabil Al-Kourainy wrote:
> Great work on the patch.  How do I implement it? Thanks.

I'm not quite sure I understand the question.  If you're running a recent trunk
build, you can add the --incognito switch to your command, e.g. chrome.exe
--incognito.  That will launch in Incognito mode.

[Nabil Al-Kourainy, 2008-10-13 19:23:02]

On 2008/10/13 19:08:08, Patrick Johnson wrote:
> On 2008/10/13 19:05:14, Nabil Al-Kourainy wrote:
> > Great work on the patch.  How do I implement it? Thanks.
> 
> I'm not quite sure I understand the question.  If you're running a recent
trunk
> build, you can add the --incognito switch to your command, e.g. chrome.exe
> --incognito.  That will launch in Incognito mode.

@Patrick Johnson: I'm not sure what command you are referring to.  How do I add
the --incognito to the chrome.exe? I have updated to the latest development
build. Thanks.

[Patrick Johnson, 2008-10-13 19:34:19]

On 2008/10/13 19:23:02, Nabil Al-Kourainy wrote:
> On 2008/10/13 19:08:08, Patrick Johnson wrote:
> > On 2008/10/13 19:05:14, Nabil Al-Kourainy wrote:
> > > Great work on the patch.  How do I implement it? Thanks.
> > 
> > I'm not quite sure I understand the question.  If you're running a recent
> trunk
> > build, you can add the --incognito switch to your command, e.g. chrome.exe
> > --incognito.  That will launch in Incognito mode.
> 
> @Patrick Johnson: I'm not sure what command you are referring to.  How do I
add
> the --incognito to the chrome.exe? I have updated to the latest development
> build. Thanks.

I don't think this is available in the latest dev channel release of Google
Chrome, 0.3.154.0.  If you are on a recent trunk build of Chromium, you will
have this option.  It looks like this was committed in Chromium revision 3013. 
Typing about:version will tell you what revision you are currently using.

In order to enable this, you will need to add --incognito to your command.  You
are probably using a shortcut, so right-click on it > Properties > and add
--incognito to the end of the "Target" section.