Issue 4308001: Remove regexp caching.

Issue 4308001: Remove regexp caching. (Closed)

Created:
10 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Patch Set 2 : Addressed some changes that were introduced since this patch was originally made. #

Total comments: 4

Patch Set 3 : Removed RegExpCloneResult #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -475 lines)			Patch
M	src/arm/codegen-arm.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View		1 chunk	+0 lines, -67 lines	0 comments	Download
M	src/full-codegen.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		1 chunk	+0 lines, -82 lines	0 comments	Download
M	src/regexp.js	View	1	11 chunks	+22 lines, -97 lines	0 comments	Download
M	src/runtime.h	View		3 chunks	+1 line, -3 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+0 lines, -60 lines	0 comments	Download
M	src/string.js	View	1 2	6 chunks	+5 lines, -70 lines	0 comments	Download
M	src/x64/codegen-x64.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View		1 chunk	+0 lines, -80 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

http://codereview.chromium.org/4308001/diff/1/2 File src/regexp.js (right): http://codereview.chromium.org/4308001/diff/1/2#newcode162 src/regexp.js:162: if (%_ArgumentsLength() == 0) { Change to === again. ...

10 years, 1 month ago (2010-11-02 12:44:38 UTC) #2

sandholm

DBC http://codereview.chromium.org/4308001/diff/5001/6001 File src/regexp.js (left): http://codereview.chromium.org/4308001/diff/5001/6001#oldcode201 src/regexp.js:201: return %_RegExpCloneResult(cache.answer); You can safely remove all the ...

10 years, 1 month ago (2010-11-02 13:11:33 UTC) #3

Lasse Reichstein

http://codereview.chromium.org/4308001/diff/5001/6001 File src/regexp.js (left): http://codereview.chromium.org/4308001/diff/5001/6001#oldcode201 src/regexp.js:201: return %_RegExpCloneResult(cache.answer); Good point. Good for code size. http://codereview.chromium.org/4308001/diff/5001/6002 ...

10 years, 1 month ago (2010-11-02 13:30:45 UTC) #4

LGTM

Expand Messages | Collapse Messages