Issue 43073: Add support for running the tests through valgrind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43073: Add support for running the tests through valgrind. (Closed)

Created:
11 years, 9 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add support for running the tests through valgrind. Committed: http://code.google.com/p/v8/source/detail?r=1493

Patch Set 1 #

Total comments: 3

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -1 line)			Patch
	A	tools/run-valgrind.py	View		1 chunk	+51 lines, -0 lines	3 comments	Download
	M	tools/test.py	View		2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 9 months ago (2009-03-11 15:12:54 UTC) #2

Does it lint?

Lgtm.

http://codereview.chromium.org/43073/diff/1/2
File tools/run-valgrind.py (right):

http://codereview.chromium.org/43073/diff/1/2#newcode1
Line 1: #!/usr/bin/python
Copyright?

http://codereview.chromium.org/43073/diff/1/2#newcode34
Line 34: "  possibly lost: \d+ bytes in \d+ blocks.")
Any reason not to use r"(?:definitely|indirectly|possibly) lost:...".

http://codereview.chromium.org/43073/diff/1/2#newcode37
Line 37: for line in errors:
Simpler might be to use re.findall.

Expand Messages | Collapse Messages