Fix exception propagation problem where undefined was returned instead...

src/top.h

Index: src/top.h
===================================================================
--- src/top.h	(revision 1483)
+++ src/top.h	(working copy)
@@ -158,10 +158,12 @@
   }
 
   static void setup_external_caught() {
-    thread_local_.external_caught_exception_ =
-        (!thread_local_.pending_exception_->IsTheHole()) &&
-        (thread_local_.catcher_ != NULL) &&
-        (Top::thread_local_.try_catch_handler_ == Top::thread_local_.catcher_);
+    if (!thread_local_.external_caught_exception_) {

[Søren Thygesen Gjesse, 2009/03/11 10:44:18]

Is this if just to avoid recalculation, or is there a subtle reason for it? Good
to get rid of IsTheHole in here.

[Mads Ager (chromium), 2009/03/11 11:09:52]

The external_caught_exception flag has to be sticky while propagating the
exception out.  It will be explicitly cleared when it is OK to do so.

+      thread_local_.external_caught_exception_ =
+          has_pending_exception() &&
+          (thread_local_.catcher_ != NULL) &&
+          (thread_local_.try_catch_handler_ == thread_local_.catcher_);
+    }
   }
 
   // Tells whether the current context has experienced an out of memory