Issue 43069: file_util::Move fails on Windows if moving a directory...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43069: file_util::Move fails on Windows if moving a directory... (Closed)

Created:
11 years, 9 months ago by huanr

Modified:
9 years ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

file_util::Move fails on Windows if moving a directory across volumes. This change adds a CopyAndDeleteDirectory function, and Move falls back to CopyAndDeleteDirectory if moving directory fails. BUG=8505 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11460

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -2 lines)			Patch
M	base/file_util.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	base/file_util_unittest.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	base/file_util_win.cc	View	2 chunks	+25 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages