Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 43043: Prompt the user before performing particularly expensive operations.... (Closed)

Created:
11 years, 9 months ago by Markus (顧孟勤)
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Prompt the user before performing particularly expensive operations. This should help users that have slow network connections. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11378

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M build/install-build-deps.sh View 1 3 chunks +62 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Markus (顧孟勤)
The script is a lot more verbose and interactive now, whenever we need to perform ...
11 years, 9 months ago (2009-03-10 21:33:21 UTC) #1
Evan Martin
11 years, 9 months ago (2009-03-10 21:40:28 UTC) #2
Looks good, minor comments below.

http://codereview.chromium.org/43043/diff/1/2
File build/install-build-deps.sh (right):

http://codereview.chromium.org/43043/diff/1/2#newcode48
Line 48: yes_no() {
Could you add a comment documenting the argument?  (It looks like it's the
default result for pressing enter?)

http://codereview.chromium.org/43043/diff/1/2#newcode69
Line 69: *)     (tput bel) 2>/dev/null
Does this beep?  Maybe we could just repeat the question instead.  I hate
beeping.

http://codereview.chromium.org/43043/diff/1/2#newcode115
Line 115: echo "Do you want me to download all packages need to build new 32bit"
grammar: s/need/needed/

Powered by Google App Engine
This is Rietveld 408576698