Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 4304002: cashew: don't invoke D-Bus methods from within a D-Bus handler (Closed)

Created:
10 years, 1 month ago by Vince Laviano
Modified:
9 years ago
Reviewers:
Jason Glasgow
CC:
chromium-os-reviews_chromium.org, Vince Laviano
Visibility:
Public.

Description

cashew: don't invoke D-Bus methods from within a D-Bus handler Call D-Bus methods from main loop to avoid deadlock (see issue 8486) Set D-Bus connection timeout to 1 sec instead of using 25 sec default Retry failed or timed out D-Bus calls BUG=chromium-os:8516 TEST=Manual testing on device, with flimflam running and not running. Change-Id: I27de7b539ceacc0471e89f595154fdb04fd74e5a Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6b01cf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -34 lines) Patch
M src/device.h View 4 chunks +31 lines, -1 line 0 comments Download
M src/device.cc View 7 chunks +78 lines, -10 lines 0 comments Download
M src/main.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M src/service.h View 3 chunks +29 lines, -1 line 0 comments Download
M src/service.cc View 9 chunks +80 lines, -12 lines 0 comments Download
M src/service_manager.h View 2 chunks +29 lines, -1 line 0 comments Download
M src/service_manager.cc View 5 chunks +76 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vince Laviano
Here's a first cut at the D-Bus patch. The goals here are: 1) Don't call ...
10 years, 1 month ago (2010-11-03 03:10:34 UTC) #1
Jason Glasgow
LGTM with the following caveat: Yes, there is code duplication. Yes you should implement a ...
10 years, 1 month ago (2010-11-03 16:45:23 UTC) #2
Vince Laviano
10 years, 1 month ago (2010-11-03 18:33:11 UTC) #3
Ok. I've filed issue 8654 to track the refactoring work.

Powered by Google App Engine
This is Rietveld 408576698