Issue 43023: Add a test case for bug 269

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43023: Add a test case for bug 269 (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

See http://code.google.com/p/v8/issues/detail?id=269. BUG=269 Committed: http://code.google.com/p/v8/source/detail?r=1484

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -0 lines)			Patch
	A	test/mjsunit/bugs/bug-269.js	View		1 chunk	+49 lines, -0 lines	0 comments	Download
	M	test/mjsunit/mjsunit.status	View		2 chunks	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/43023/diff/1/3 File test/mjsunit/mjsunit.status (right): http://codereview.chromium.org/43023/diff/1/3#newcode42 Line 42: bugs/bug-269: CRASH, FAIL if $mode == debug ...

11 years, 9 months ago (2009-03-10 19:39:29 UTC) #2

Søren Thygesen Gjesse

11 years, 9 months ago (2009-03-11 08:15:09 UTC) #3

http://codereview.chromium.org/43023/diff/1/3
File test/mjsunit/mjsunit.status (right):

http://codereview.chromium.org/43023/diff/1/3#newcode42
Line 42: bugs/bug-269: CRASH, FAIL if $mode == debug
On 2009/03/10 19:39:29, Mads Ager wrote:
> Do you need this line?  All tests in the bugs directory are expected to fail. 
> Maybe they are not expected to crash?

Exactly, tests in the bugs directory are expected to fail, not crash. I find
this is the right thing to do therefore the extra line.

Expand Messages | Collapse Messages