Issue 43017: Add end of file newline checks to PRESUBMIT.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43017: Add end of file newline checks to PRESUBMIT.py. (Closed)

Created:
11 years, 9 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add end of file newline checks to PRESUBMIT.py. This makes sure that: - Files end in a newline character, this is otherwise a fatal error with GCC. - Files end in only one newline character, and not a bunch of whitespace.

Patch Set 1 #

Patch Set 2 : Only check for \n if the file isn't empty. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	PRESUBMIT.py	View	1	3 chunks	+10 lines, -0 lines	0 comments	Download
	M	PRESUBMIT_unittest.py	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages