Issue 43008: Make unique id to all scripts work with snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43008: Make unique id to all scripts work with snapshot (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Moved the storage of the last script id into the heap to make it part of the serialized data when starting V8 on a snapshot. Currently the script ids wrap when positive smi value is exhausted. Committed: http://code.google.com/p/v8/source/detail?r=1474

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -5 lines)			Patch
M	src/factory.cc	View	1 chunk	+18 lines, -3 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/heap-inl.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/mjsunit/debug-setbreakpoint.js	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

Should I remove Factory::NewNumberFromUint as well? It is not used anymore.

11 years, 9 months ago (2009-03-10 10:54:36 UTC) #1

Mads Ager (chromium)

11 years, 9 months ago (2009-03-10 11:23:20 UTC) #2

LGTM

Yes, please remove the dead code as well.

Expand Messages | Collapse Messages