Fix probably harmless thinko in StringCharAt (causes...

Fix probably harmless thinko in StringCharAt (causes
slow-case code to be run).

Committed: http://code.google.com/p/v8/source/detail?r=1470

[Lasse Reichstein, 2009-03-10 08:50:09]

LGTM, if this is what you want.

http://codereview.chromium.org/43005/diff/1/2
File src/string.js (right):

http://codereview.chromium.org/43005/diff/1/2#newcode65
Line 65: var subject = ToString(this);
This changes the behavior on non-string receivers to potentially use the fast
case, but at the cost of an extra is-this-a-string check in the case where the
receiver is a string.
The assumption made was that non-string receivers of String.prototype.charAt are
so rare that they can be ignored (even if charAt is intentionally generic).

Ofcourse, this depends on the receiver not being a temporary String wrapper
object.

[Lasse Reichstein, 2009-03-10 08:56:01]

http://codereview.chromium.org/43005/diff/1/2
File src/string.js (right):

http://codereview.chromium.org/43005/diff/1/2#newcode65
Line 65: var subject = ToString(this);
My bad. The real problem was ofcourse that subject was used before it was
initialized.