Revert change that disallowed content scripts access to file://

Revert change that disallowed content scripts access to 
file:// URLs. It turns out teams were already depending on 
this and we didn't want to break them.

Instead, group file:// access with NPAPI in the extension
install prompt.

Note: this is a pure revert of r402029 and r402069 (sorry 
Finnur!) except the changes in extension_install_ui.cc, 
which are new.

BUG=28456
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32770

[Finnur, 2009-11-21 17:02:24]

http://codereview.chromium.org/430003/diff/1/2
File chrome/browser/extensions/extension_browsertests_misc.cc (right):

http://codereview.chromium.org/430003/diff/1/2#newcode229
Line 229: 
Why not leave this in and just revert the part that ignores 'file://' in
'matches', given that using http in tests should be preferable, no?

http://codereview.chromium.org/430003/diff/1/3
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/430003/diff/1/3#newcode48
Line 48: extension->content_scripts().begin();
nit: this should probably be indented a little more, no?

http://codereview.chromium.org/430003/diff/1/3#newcode52
Line 52: script->url_patterns().begin();
nit: same here?

http://codereview.chromium.org/430003/diff/1/7
File chrome/browser/extensions/user_script_listener_unittest.cc (right):

http://codereview.chromium.org/430003/diff/1/7#newcode298
Line 298: // Loads a single extension and ensures that requests to URLs with
content
This should not be reverted, I guess. The comment was wrong.

http://codereview.chromium.org/430003/diff/1/8
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/430003/diff/1/8#newcode190
Line 190: // By default, cookies are not allowed on file://. They are needed in
for
This is also a grammar error that we should not revert...?

http://codereview.chromium.org/430003/diff/1/30
File chrome/test/data/extensions/subscribe_page_action/manifest.json (right):

http://codereview.chromium.org/430003/diff/1/30#newcode4
Line 4: "version": "1.6.2",
Given that this extension is live on the gallery we should probably not
decrement the version number.

[Aaron Boodman, 2009-11-21 23:26:32]

All good points. Have another look?

http://codereview.chromium.org/430003/diff/1/2
File chrome/browser/extensions/extension_browsertests_misc.cc (right):

http://codereview.chromium.org/430003/diff/1/2#newcode229
Line 229: 
On 2009/11/21 17:02:25, Finnur wrote:
> Why not leave this in and just revert the part that ignores 'file://' in
> 'matches', given that using http in tests should be preferable, no?

Fair enough. Done.

http://codereview.chromium.org/430003/diff/1/3
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/430003/diff/1/3#newcode48
Line 48: extension->content_scripts().begin();
On 2009/11/21 17:02:25, Finnur wrote:
> nit: this should probably be indented a little more, no?

Done.

http://codereview.chromium.org/430003/diff/1/3#newcode52
Line 52: script->url_patterns().begin();
On 2009/11/21 17:02:25, Finnur wrote:
> nit: same here?

Done.

http://codereview.chromium.org/430003/diff/1/7
File chrome/browser/extensions/user_script_listener_unittest.cc (right):

http://codereview.chromium.org/430003/diff/1/7#newcode298
Line 298: // Loads a single extension and ensures that requests to URLs with
content
On 2009/11/21 17:02:25, Finnur wrote:
> This should not be reverted, I guess. The comment was wrong.

Done.

[Finnur, 2009-11-22 00:13:44]

>> Why not leave this in and just revert the part that ignores 'file://' in
>> 'matches', given that using http in tests should be preferable, no?

> Fair enough. Done.

I'm confused. The tests still look like they are being converted back to file://

?

http://codereview.chromium.org/430003/diff/2003/2004
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/430003/diff/2003/2004#newcode52
Line 52: script->url_patterns().begin();
nit: That looks like 3 spaces, not 4... ? :) Also above.

[Finnur, 2009-11-22 00:27:15]

LG.

I'll leave it up to you to decide if you want to keep some of those tests as
http:// instead of file://.

On 2009/11/22 00:13:44, Finnur wrote:
> >> Why not leave this in and just revert the part that ignores 'file://' in
> >> 'matches', given that using http in tests should be preferable, no?
> 
> > Fair enough. Done.
> 
> I'm confused. The tests still look like they are being converted back to
file://
> 
> ?
> 
> http://codereview.chromium.org/430003/diff/2003/2004
> File chrome/browser/extensions/extension_install_ui.cc (right):
> 
> http://codereview.chromium.org/430003/diff/2003/2004#newcode52
> Line 52: script->url_patterns().begin();
> nit: That looks like 3 spaces, not 4... ? :) Also above.