Issue 430002: Unit test for back/forward for url fragments. Improvements in the testing...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 430002: Unit test for back/forward for url fragments. Improvements in the testing... (Closed)

Created:
11 years, 1 month ago by amit

Modified:
9 years ago

Reviewers:
ananta, stoyan

CC:
chromium-reviews_googlegroups.com, amit, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Unit test for back/forward for url fragments. Improvements in the testing framwork include a non-scriptable interface for getting window handles from chrome frame activex and methods for sending input in the WebBrowserSink. BUG=none TEST=back forward unit test for url fragments (anchor) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32882

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+227 lines, -18 lines)			Patch
M	chrome_frame/test/chrome_frame_test_utils.cc	View	1 2 3 4 5 6 7 8 9	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_unittests.h	View	1 2 3 4 5 6 7 8 9	3 chunks	+10 lines, -11 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_unittests.cc	View	1 2 3 4 5 6 7 8 9	8 chunks	+213 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stoyan

LGtm Is there any special reasons for IChromeFrameNOnScriptable besides gettting window handles? You can use ...

11 years, 1 month ago (2009-11-23 18:47:58 UTC) #2

LGTM

Expand Messages | Collapse Messages