Issue 4292001: Add basic support for accessibility hit testing within web contents....

Issue 4292001: Add basic support for accessibility hit testing within web contents.... (Closed)

Created:
10 years, 1 month ago by Chris Guillory

Modified:
9 years, 7 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org, David Tseng

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add basic support for accessibility hit testing within web contents. BUG=59890 TEST=Manual. Inspect32. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64943

Patch Set 1 #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -57 lines)			Patch
M	chrome/browser/accessibility/browser_accessibility.h	View	1 chunk	+20 lines, -0 lines	2 comments	Download
M	chrome/browser/accessibility/browser_accessibility.cc	View	2 chunks	+63 lines, -0 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_manager.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_manager.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_win.h	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/accessibility/browser_accessibility_win.cc	View	4 chunks	+24 lines, -42 lines	0 comments	Download
M	webkit/glue/webaccessibility.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webaccessibility.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Guillory

Ready for review. This requires a WebKit side patch which is in CR: https://bugs.webkit.org/show_bug.cgi?id=48817 - ...

10 years, 1 month ago (2010-11-02 03:01:33 UTC) #1

dmazzoni

LGTM. http://codereview.chromium.org/4292001/diff/1/3 File chrome/browser/accessibility/browser_accessibility.h (right): http://codereview.chromium.org/4292001/diff/1/3#newcode100 chrome/browser/accessibility/browser_accessibility.h:100: bool HasAttribute(WebAccessibility::Attribute attribute); Should the Attribute methods maybe ...

10 years, 1 month ago (2010-11-03 02:21:52 UTC) #2

Chris Guillory

10 years, 1 month ago (2010-11-03 17:17:50 UTC) #3

http://codereview.chromium.org/4292001/diff/1/3
File chrome/browser/accessibility/browser_accessibility.h (right):

http://codereview.chromium.org/4292001/diff/1/3#newcode100
chrome/browser/accessibility/browser_accessibility.h:100: bool
HasAttribute(WebAccessibility::Attribute attribute);
On 2010/11/03 02:21:53, Dominic Mazzoni wrote:
> Should the Attribute methods maybe be protected instead of public?

Done.

Expand Messages | Collapse Messages