Convert implicit scoped_refptr constructor calls to explicit ones, part 2

Convert implicit scoped_refptr constructor calls to explicit ones, part 2

This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2826041
I then did quite a bit of manual editing to fix style issues.

BUG=28083
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64798

[Nico, 2010-11-02 04:42:48]

(This doesn't fix all instances for reasons I don't understand yet.
But I figured this is probably nicer to review in chunks anyway)

On Tue, Nov 2, 2010 at 12:38 AM,  <thakis@chromium.org> wrote:
> Reviewers: jamesr,
>
> Description:
> Convert implicit scoped_refptr constructor calls to explicit ones, part 2
>
> This CL was created automatically by this clang rewriter:
> http://codereview.appspot.com/2826041
> I then did quite a bit of manual editing to fix style issues.
>
> BUG=28083
> TEST=None
>
> Please review this at http://codereview.chromium.org/4291001/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/build
>
> Affected files:
>  M chrome/browser/automation/testing_automation_provider.cc
>  M chrome/browser/extensions/extension_cookies_api.cc
>  M chrome/browser/extensions/extension_toolbar_model.cc
>  M chrome/browser/extensions/extensions_service.cc
>  M chrome/browser/extensions/extensions_service_unittest.cc
>  M chrome/browser/memory_purger.cc
>  M chrome/browser/printing/print_job_manager.cc
>  M chrome/browser/sync/engine/apply_updates_command_unittest.cc
>  M chrome/browser/sync/engine/process_commit_response_command_unittest.cc
>  M chrome/browser/sync/engine/verify_updates_command_unittest.cc
>  M chrome/renderer/render_view.cc
>  M chrome/test/automation/dom_element_proxy.cc
>  M ipc/ipc_channel_proxy.cc
>  M media/base/pipeline_impl.cc
>  M media/filters/ffmpeg_demuxer.cc
>  M net/base/host_resolver_impl.cc
>  M net/disk_cache/file_posix.cc
>  M net/disk_cache/in_flight_backend_io.cc
>  M net/disk_cache/in_flight_io.cc
>  M net/http/http_network_transaction.cc
>  M net/http/http_proxy_client_socket.cc
>  M net/proxy/init_proxy_resolver.cc
>  M net/proxy/multi_threaded_proxy_resolver.cc
>  M net/proxy/proxy_bypass_rules.cc
>  M net/proxy/proxy_service.cc
>  M net/socket/client_socket_handle.cc
>  M net/socket/client_socket_pool_base.cc
>  M net/socket/socks5_client_socket.cc
>  M net/socket/ssl_client_socket_nss.cc
>  M net/socket/tcp_client_socket_libevent.cc
>  M net/socket/tcp_client_socket_pool.cc
>  M net/socket_stream/socket_stream.cc
>  M net/spdy/spdy_http_stream.cc
>  M net/spdy/spdy_network_transaction_unittest.cc
>  M net/spdy/spdy_proxy_client_socket.cc
>  M net/spdy/spdy_session.cc
>  M net/spdy/spdy_session_pool.cc
>  M net/spdy/spdy_stream.cc
>  M net/url_request/url_request.cc
>  M net/websockets/websocket.cc
>  M net/websockets/websocket_job.cc
>  M remoting/base/multiple_array_input_stream.cc
>  M remoting/base/tracer.cc
>  M remoting/protocol/jingle_chromotocol_server.cc
>  M remoting/protocol/message_decoder.cc
>  M remoting/protocol/protocol_test_client.cc
>  M webkit/appcache/appcache_storage_impl.cc
>  M webkit/appcache/mock_appcache_storage.cc
>  M webkit/glue/plugins/pepper_file_chooser.cc
>  M webkit/glue/plugins/plugin_instance.cc
>  M webkit/glue/plugins/plugin_lib.cc
>  M webkit/glue/webmediaplayer_impl.cc
>
>
>

[jamesr, 2010-11-02 08:20:59]

http://codereview.chromium.org/4291001/diff/12001/13001
File chrome/browser/automation/testing_automation_provider.cc (right):

http://codereview.chromium.org/4291001/diff/12001/13001#newcode566
chrome/browser/automation/testing_automation_provider.cc:566: url, cookie_name,
think this should be 4-space indented, no?

http://codereview.chromium.org/4291001/diff/12001/13035
File net/spdy/spdy_proxy_client_socket.cc (right):

http://codereview.chromium.org/4291001/diff/12001/13035#newcode410
net/spdy/spdy_proxy_client_socket.cc:410: new DrainableIOBuffer(io_buffer,
length)));
think you wanna move the make_scoped_refptr down to the next line here

[Nico, 2010-11-02 14:34:01]

All excellent points.

http://codereview.chromium.org/4291001/diff/12001/13001
File chrome/browser/automation/testing_automation_provider.cc (right):

http://codereview.chromium.org/4291001/diff/12001/13001#newcode566
chrome/browser/automation/testing_automation_provider.cc:566: url, cookie_name,
On 2010/11/02 08:21:00, jamesr wrote:
> think this should be 4-space indented, no?

Done.

http://codereview.chromium.org/4291001/diff/12001/13035
File net/spdy/spdy_proxy_client_socket.cc (right):

http://codereview.chromium.org/4291001/diff/12001/13035#newcode410
net/spdy/spdy_proxy_client_socket.cc:410: new DrainableIOBuffer(io_buffer,
length)));
On 2010/11/02 08:21:00, jamesr wrote:
> think you wanna move the make_scoped_refptr down to the next line here

If you say so. Done.

[jamesr, 2010-11-02 20:03:56]

LGTM