Add explicit build dependencies from npchrome_frame to chrome and chrome_dll....

Add explicit build dependencies from npchrome_frame to chrome and chrome_dll. This is to avoid having non-versioned matched components in the build directory if only buildingg npchrome_frame which causes all manner of trouble.

BUG=version-mismatched binaries can reside in the build folder when building only npchrome_frame
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64759

[amit, 2010-11-02 16:49:30]

lg, thanks!

On Mon, Nov 1, 2010 at 8:12 PM, <robertshield@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Add explicit build dependencies from npchrome_frame to chrome and
> chrome_dll.
> This is to avoid having non-versioned matched components in the build
> directory
> if only buildingg npchrome_frame which causes all manner of trouble.
>
> BUG=version-mismatched binaries can reside in the build folder when
> building
> only npchrome_frame
> TEST=NONE
>
>
> Please review this at http://codereview.chromium.org/4288001/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/chrome_frame.gyp
>
>
> Index: chrome_frame/chrome_frame.gyp
> ===================================================================
> --- chrome_frame/chrome_frame.gyp       (revision 64609)
> +++ chrome_frame/chrome_frame.gyp       (working copy)
> @@ -839,6 +839,8 @@
>         '../build/temp_gyp/googleurl.gyp:googleurl',
>         'chrome_frame_launcher.gyp:chrome_frame_helper',
>         'chrome_frame_launcher.gyp:chrome_frame_helper_dll',
> +        '../chrome/chrome.gyp:chrome',
> +        '../chrome/chrome.gyp:chrome_dll',
>         '../chrome/chrome.gyp:chrome_version_header',
>         '../chrome/chrome.gyp:common',
>         '../chrome/chrome.gyp:utility',
>
>
>