Issue 4287002: Mac: Accelerated views should delegate firstResponder to the RWHVMac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4287002: Mac: Accelerated views should delegate firstResponder to the RWHVMac (Closed)

Created:
10 years, 1 month ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, pink (ping after 24hrs)

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Mac: Accelerated views should delegate firstResponder to the RWHVMac BUG=60318 TEST=See bug (enable html5 video on youtube, watch a video, click omnibox, click youtube search box. It should focus. Same on grooveshark: the search box should focus when clicked after clicking the omnibox) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64784

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

10 years, 1 month ago (2010-11-02 16:55:14 UTC) #2

LGTM assuming you've double-checked that this doesn't regress keyboard focus for
accelerated plugins.

Expand Messages | Collapse Messages