Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: webkit/glue/webframe_impl.h

Issue 4283: Fix bug 455: Active match in Find is not selected and links are not focused a... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webframe.h ('k') | webkit/glue/webframe_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webframe_impl.h
===================================================================
--- webkit/glue/webframe_impl.h (revision 2542)
+++ webkit/glue/webframe_impl.h (working copy)
@@ -124,7 +124,7 @@
gfx::Rect* selection_rect);
virtual bool FindNext(const FindInPageRequest& request,
bool wrap_within_frame);
- virtual void StopFinding();
+ virtual void StopFinding(bool clear_selection);
virtual void ScopeStringMatches(FindInPageRequest request, bool reset);
virtual void CancelPendingScopingEffort();
virtual void ResetMatchCount();
@@ -251,6 +251,14 @@
return active_tickmark_;
}
+ // When a Find operation ends, we want to set the selection to what was active
+ // and set focus to the first focusable node we find (starting with the first
+ // node in the matched range and going up the inheritance chain). If we find
+ // nothing to focus we focus the first focusable node in the range. This
+ // allows us to set focus to a link (when we find text inside a link), which
+ // allows us to navigate by pressing Enter after closing the Find box.
+ void SetFindEndstateFocusAndSelection();
+
// Sets whether the WebFrameImpl allows its document to be scrolled.
// If the parameter is true, allow the document to be scrolled.
// Otherwise, disallow scrolling
« no previous file with comments | « webkit/glue/webframe.h ('k') | webkit/glue/webframe_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698