chrome/browser/cocoa/import_settings_dialog.mm - Issue 4282003: Fix type inconsistency with StartImportingWithUI and ProfileInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/import_settings_dialog.mm

Issue 4282003: Fix type inconsistency with StartImportingWithUI and ProfileInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/import_settings_dialog.mm

diff --git a/chrome/browser/cocoa/import_settings_dialog.mm b/chrome/browser/cocoa/import_settings_dialog.mm

index a11244aef56d15dbeafb2497ce960d86ba9a9a53..d18dec8995d8ff0ad85204f1e79dd581c5d6fca9 100644

--- a/chrome/browser/cocoa/import_settings_dialog.mm

+++ b/chrome/browser/cocoa/import_settings_dialog.mm

@@ -174,9 +174,7 @@ bool importSettingsDialogVisible = false;

const importer::ProfileInfo& sourceProfile =

importerList_.get()->GetSourceProfileInfoAt([self sourceBrowserIndex]);

uint16 items = sourceProfile.services_supported;

- // ProfileInfo.services_supported is a uint16 while the call to

- // StartImportingWithUI requires an int16.

- int16 servicesToImport = static_cast<int16>(items & [self servicesToImport]);

+ uint16 servicesToImport = items & [self servicesToImport];

if (servicesToImport) {

if (profile_) {

ImporterHost* importerHost = new ExternalProcessImporterHost;