Issue 4281003: Fixed mismatched channel order in OSMesaViewGLContext....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4281003: Fixed mismatched channel order in OSMesaViewGLContext.... (Closed)

Created:
10 years, 1 month ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
greggman

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixed mismatched channel order in OSMesaViewGLContext. Made failing SwapBuffers not an error. We have a race condition whereby a window can be closed while the GPU process is rendering. This could make ui and browser tests flaky. TEST=try, make sure color channels are not reversed BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64858

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	app/gfx/gl/gl_context_win.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

greggman

10 years, 1 month ago (2010-11-03 01:05:04 UTC) #2

I didn't see the part about making failing swapbuffer not an error.

Did you mean UpdateSize not actually calling context_.Resize if GetClientSize
fails?

lgtm

Expand Messages | Collapse Messages