Avoid losing CL description during Rietveld outage....

Avoid losing CL description during Rietveld outage.

Save the CL locally prior to attempting to submit
to Rietveld.  The CL is saved locally with a dirty-bit
before the upload is attempted.  If successful, the CL
is saved locally again with a clean-bit.

On loading a dirty CL for editing, we only load the
CL description from Rietveld if the local CL is clean
(there are no pending changes to upload).  Clean CLs
continue to retrieve updated descriptions directly
from Rietveld.

BUG=none
TEST=gcl change <name> saves CL description local
prior to uploading.  gcl change <name> after a failed
Rietveld upload uses local CL description instead of
using the associated issue's description from Rietveld.
Changes in this state are reset to the 'clean' state
after the Rietveld update completes.

[jam, 2009-11-20 23:31:09]

http://codereview.chromium.org/428001/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/428001/diff/1/2#newcode1053
Line 1053: print description
Why print it then?  


I feel gcl is already way too verbose.  We should only print out the description
if it changed and couldn't be saved.

[chase, 2009-11-21 06:25:20]

Thanks for the feedback, updated patch, PTAL.

[M-A Ruel, 2009-11-22 18:06:10]

lgtm

http://codereview.chromium.org/428001/diff/4002/2002
File gcl.py (right):

http://codereview.chromium.org/428001/diff/4002/2002#newcode320
Line 320: data = ChangeInfo._SEPARATOR.join([
We should have used json or pickle right at the start... :(

[jam, 2009-11-23 05:36:33]

lgtm

[jam, 2010-04-28 17:21:59]

hey Chase, so I just discovered a bug with this.  If someone makes a change and
then edits the descriptino on the server, next time they run gcl change the
description isn't fetched from the server.  this is a regression.

[chase, 2010-05-10 01:32:32]

John, were you able to reproduce this?