Issue 4280002: Adding both for branch preflight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4280002: Adding both for branch preflight (Closed)

Created:
10 years, 1 month ago by scottz

Modified:
9 years, 7 months ago

Reviewers:
davidjames, David James, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils@master

Visibility:
Public.

Description

Adding both for branch preflight BUG=NA TEST=NA Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cb8c73b

Patch Set 1 #

Total comments: 1

Patch Set 2 : add comma #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	bin/cbuildbot_config.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scottz

Fix incorrect assumption, I should have actually read the description at the top.

10 years, 1 month ago (2010-11-02 05:40:50 UTC) #1

David James

10 years, 1 month ago (2010-11-02 05:41:50 UTC) #2

LGTM w/nit

'overlays': 'both', (want a trailing comma)

http://codereview.chromium.org/4280002/diff/1/2
File bin/cbuildbot_config.py (right):

http://codereview.chromium.org/4280002/diff/1/2#newcode63
bin/cbuildbot_config.py:63: 'overlays': 'both'
Please add a trailing comma for consistency with rest of file.

Expand Messages | Collapse Messages