Issue 4279002: Improve PRESUBMIT.py error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4279002: Improve PRESUBMIT.py error messages. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Improve PRESUBMIT.py error messages. TEST=presubmit.py BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64903

Patch Set 2 : Simplify #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
	M	PRESUBMIT.py	View	1	1 chunk	+14 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

http://codereview.chromium.org/4279002/diff/1/2 File PRESUBMIT.py (right): http://codereview.chromium.org/4279002/diff/1/2#newcode67 PRESUBMIT.py:67: if input_api.platform == 'win32' and e.errno == errno.ENOENT: if ...

10 years, 1 month ago (2010-11-02 18:58:12 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 4279002: Improve PRESUBMIT.py error messages. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Simplify #

Messages