Issue 4277003: Change gcl presubmit to only run commit hooks by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4277003: Change gcl presubmit to only run commit hooks by default. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Change gcl presubmit to only run commit hooks by default. Upload hook are only run with the --upload flag. Most of the time the same hook is run in both case so gcl presubmit is simply 2x slower than it could be otherwise. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64779

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix unit test #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -13 lines)			Patch
	M	gcl.py	View	1	2 chunks	+16 lines, -10 lines	0 comments	Download
	M	tests/gcl_unittest.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

10 years, 1 month ago (2010-11-02 18:55:51 UTC) #2

lgtm

please also fix git cl presubmit

http://codereview.chromium.org/4277003/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/4277003/diff/1/2#newcode888
gcl.py:888: print('\n*** Presubmit checks for COMMIT would report: ***')
nit. the \n should be superfluous now

Expand Messages | Collapse Messages