[GTK] add instant pref

[GTK] add instant pref

replace the flag with a pref. There is still a flag for verbatim matching, which sky just added.

BUG=58937
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64965

[sky, 2010-11-02 17:56:29]

http://codereview.chromium.org/4277001/diff/2001/3002
File chrome/browser/gtk/options/general_page_gtk.cc (right):

http://codereview.chromium.org/4277001/diff/2001/3002#newcode545
chrome/browser/gtk/options/general_page_gtk.cc:545: bool enabled =
gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(toggle_button));
You need to call into  browser::ShowInstantConfirmDialogIfNecessary (and you'll
need to implement browser::ShowInstantConfirmDialog). See general_page_view for
how it deals with this.

http://codereview.chromium.org/4277001/diff/2001/3002#newcode793
chrome/browser/gtk/options/general_page_gtk.cc:793: // TODO(estade): we need the
user somewhere.
Do:
browser::ShowOptionsURL(profile(),
                         GURL(browser::kInstantLearnMoreURL));

here.

[Evan Stade, 2010-11-03 00:27:47]

http://codereview.chromium.org/4277001/diff/2001/3002
File chrome/browser/gtk/options/general_page_gtk.cc (right):

http://codereview.chromium.org/4277001/diff/2001/3002#newcode545
chrome/browser/gtk/options/general_page_gtk.cc:545: bool enabled =
gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(toggle_button));
On 2010/11/02 17:56:29, sky wrote:
> You need to call into  browser::ShowInstantConfirmDialogIfNecessary (and
you'll
> need to implement browser::ShowInstantConfirmDialog). See general_page_view
for
> how it deals with this.

ok to TODO?

http://codereview.chromium.org/4277001/diff/2001/3002#newcode793
chrome/browser/gtk/options/general_page_gtk.cc:793: // TODO(estade): we need the
user somewhere.
On 2010/11/02 17:56:29, sky wrote:
> Do:
> browser::ShowOptionsURL(profile(),
>                          GURL(browser::kInstantLearnMoreURL));
> 
> here.

Done.

[sky, 2010-11-03 00:51:42]

TODO works for me.
LGTM