Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Issue 4275001: [Sync] Removed more uses of libjingle's sigslot (Closed)

Created:
10 years, 1 month ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews
Visibility:
Public.

Description

[Sync] Removed more uses of libjingle's sigslot Another speculative fix for the crash in the bug. BUG=58042 TEST=sync integration tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -70 lines) Patch
M jingle/notifier/communicator/login.h View 4 chunks +20 lines, -11 lines 0 comments Download
M jingle/notifier/communicator/login.cc View 4 chunks +14 lines, -17 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt.h View 3 chunks +14 lines, -13 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.h View 3 chunks +8 lines, -17 lines 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M jingle/notifier/listener/talk_mediator_impl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
akalin
+zea for review
10 years, 1 month ago (2010-11-02 00:17:38 UTC) #1
Nicolas Zea
10 years, 1 month ago (2010-11-02 17:31:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698