Issue 4271003: Workaround for VS 2005 bug with inheritance from nested classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4271003: Workaround for VS 2005 bug with inheritance from nested classes. (Closed)

Created:
10 years, 1 month ago by caseq

Modified:
9 years, 7 months ago

Reviewers:
akalin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Workaround for VS 2005 bug with inheritance from nested classes. BUG=http://crbug.com/61717 TEST=none

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	jingle/notifier/communicator/login.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	jingle/notifier/listener/mediator_thread_impl.h	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

caseq

Fred, looks like your recent change (r64793) triggered a bug in Visual Studio 2005 -- ...

10 years, 1 month ago (2010-11-03 13:24:38 UTC) #1

akalin

10 years, 1 month ago (2010-11-03 18:27:11 UTC) #2

LGTM, sorry for the breakage, I guess I got lucky and got the 2008 Win trybots.

On 2010/11/03 13:24:38, caseq wrote:
> Fred,
> looks like your recent change (r64793) triggered a bug in Visual Studio 2005
--
> please see http://crbug.com/61717.
> While this does not affect the bots that run VS 2008, many that use VS 2005
are
> affected. Using typedef instead of directly listing a nested class as a base
> class seems to help.

Expand Messages | Collapse Messages