Fix a test tool for OTS, ot-sanitise....

Fix a test tool for OTS, ot-sanitise.

Check if stdout is a regular file (and not a special file such as /dev/null and /dev/zero) in main() of test/ot-sanitise.cc.

BUG=27127
TEST=Run "./ot-sanitise 9de66fe4842edf59e46e15c90e686087.ttf > /dev/null" and verity that it does not trigger an assert failure.

[Evan Martin, 2009-11-21 18:34:04]

http://codereview.chromium.org/427014/diff/1/4
File test/file-stream.h (right):

http://codereview.chromium.org/427014/diff/1/4#newcode37
Line 37: const off_t current_offset = ::ftello(file_);
Rather than relying on ftello, couldn't you just keep a current_offset_ member
variable and update it whenever WriteRaw is called?

[Yusuke Sato, 2009-11-23 08:38:44]

Fixed test/file-stream.h, reverted test/README and test/ot-sanitise.cc.

http://codereview.chromium.org/427014/diff/1/4
File test/file-stream.h (right):

http://codereview.chromium.org/427014/diff/1/4#newcode37
test/file-stream.h:37: const off_t current_offset = ::ftello(file_);
Ah, that's better than mine. Fixed.
Thanks.

[Evan Martin, 2009-11-23 17:44:19]

LGTM, not sure if you want to wait for jungshik or not, seems pretty obviously
correct to me :)

http://codereview.chromium.org/427014/diff/3002/3003
File test/file-stream.h (right):

http://codereview.chromium.org/427014/diff/3002/3003#newcode23
test/file-stream.h:23: if (::fwrite(data, length, 1, file_) == 1) {
Does this function succeed when writing to /dev/null?

[Yusuke Sato, 2009-11-23 17:59:23]

http://codereview.chromium.org/427014/diff/3002/3003
File test/file-stream.h (right):

http://codereview.chromium.org/427014/diff/3002/3003#newcode23
test/file-stream.h:23: if (::fwrite(data, length, 1, file_) == 1) {
On 2009/11/23 17:44:19, Evan Martin wrote:
> Does this function succeed when writing to /dev/null? 

Yes, at least on Linux 2.6.

[Yusuke Sato, 2009-11-24 02:18:07]

Landed.
http://code.google.com/p/ots/source/detail?r=19

On 2009/11/23 17:59:23, Yusuke Sato wrote:
> http://codereview.chromium.org/427014/diff/3002/3003
> File test/file-stream.h (right):
> 
> http://codereview.chromium.org/427014/diff/3002/3003#newcode23
> test/file-stream.h:23: if (::fwrite(data, length, 1, file_) == 1) {
> On 2009/11/23 17:44:19, Evan Martin wrote:
> > Does this function succeed when writing to /dev/null? 
> 
> Yes, at least on Linux 2.6.