Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/test/startup/feature_startup_test.cc

Issue 427005: Try to make the start up tests less flaky by switching (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/startup/feature_startup_test.cc
diff --git a/chrome/test/startup/feature_startup_test.cc b/chrome/test/startup/feature_startup_test.cc
index 5f2ce166d960ea9d163b57831a00869568f70299..fcb4563b44fdeb9b6e443092081a52750ad6e4d5 100644
--- a/chrome/test/startup/feature_startup_test.cc
+++ b/chrome/test/startup/feature_startup_test.cc
@@ -80,15 +80,17 @@ class NewTabUIStartupTest : public UITest {
ASSERT_EQ(1, tab_count);
// Hit ctl-t and wait for the tab to load.
- window->ApplyAccelerator(IDC_NEW_TAB);
- ASSERT_TRUE(window->WaitForTabCountToBecome(2, 5000));
+ window->RunCommand(IDC_NEW_TAB);
+ ASSERT_TRUE(window->GetTabCount(&tab_count));
+ ASSERT_EQ(2, tab_count);
int load_time;
ASSERT_TRUE(automation()->WaitForInitialNewTabUILoad(&load_time));
if (want_warm) {
// Bring up a second tab, now that we've already shown one tab.
- window->ApplyAccelerator(IDC_NEW_TAB);
- ASSERT_TRUE(window->WaitForTabCountToBecome(3, 5000));
+ window->RunCommand(IDC_NEW_TAB);
+ ASSERT_TRUE(window->GetTabCount(&tab_count));
+ ASSERT_EQ(3, tab_count);
ASSERT_TRUE(automation()->WaitForInitialNewTabUILoad(&load_time));
}
timings[i] = TimeDelta::FromMilliseconds(load_time);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698