Disk Cache: Second pass (and final) to allow multiple instances...

Disk Cache: Second pass (and final) to allow multiple instances
of BackendImpl.

This cl takes care of all the histograms on the disk cache. Most
of them have to be splitted in three so that we get separate data
from different cache types. There are a few places where the complexity
of splitting the histogram is not worth it so we just keep either all
data together (if it makes sense), or just ignore data for some types of
caches.

note: Having multiple versions of a histogram but only one "active" for a
given client is not the same as having multiple histograms working at the
same time for different objects.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12692

[Nicolas Sylvain, 2009-03-27 17:59:07]

lgtm

http://codereview.chromium.org/42682/diff/10/13
File net/disk_cache/backend_impl.h (right):

http://codereview.chromium.org/42682/diff/10/13#newcode113
Line 113: net::CacheType cache_type() { return cache_type_; }
style?

http://codereview.chromium.org/42682/diff/10/12
File net/disk_cache/histogram_macros.h (right):

http://codereview.chromium.org/42682/diff/10/12#newcode28
Line 28: #define UMA_HISTOGRAM_ERROR(name, sample) do { \
UMA_HISTOGRAM_CACHE_ERROR maybe?

http://codereview.chromium.org/42682/diff/10/12#newcode63
Line 63: break;\
NOTREACHED?

[rvargas (doing something else), 2009-03-27 20:13:54]

All comments fixed. Thanks.

On 2009/03/27 17:59:07, Nicolas Sylvain wrote:
> lgtm
> 
> http://codereview.chromium.org/42682/diff/10/13
> File net/disk_cache/backend_impl.h (right):
> 
> http://codereview.chromium.org/42682/diff/10/13#newcode113
> Line 113: net::CacheType cache_type() { return cache_type_; }
> style?
> 
> http://codereview.chromium.org/42682/diff/10/12
> File net/disk_cache/histogram_macros.h (right):
> 
> http://codereview.chromium.org/42682/diff/10/12#newcode28
> Line 28: #define UMA_HISTOGRAM_ERROR(name, sample) do { \
> UMA_HISTOGRAM_CACHE_ERROR maybe?
> 
> http://codereview.chromium.org/42682/diff/10/12#newcode63
> Line 63: break;\
> NOTREACHED?