Issue 42681: After r12485, every POST request has an UploadData,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42681: After r12485, every POST request has an UploadData,... (Closed)

Created:
11 years, 9 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

After r12485, every POST request has an UploadData, even if no data needs to be uploaded, so that we can set the identifier field in UploadData. So we should now enter the STATE_WRITE_BODY state only if request_body_stream_ has a nonzero size, so that we won't call connection_.socket()->Write() with zero bytes. R=darin BUG=9347 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12660

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	net/http/http_network_transaction.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Thanks for fixing this!

Expand Messages | Collapse Messages