Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 4268: IsStringUTF8 unittest and enforcing UTF-8 in JSON deserialization (Closed)

Created:
12 years, 3 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add UTF-8 check for JSON deserializer. Add tests for IsStringUTF8 Make IsStringUTF8 accept std::string/std::wstring rather than char*/wchar_t* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2610

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -14 lines) Patch
M base/json_reader.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M base/json_reader_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M base/string_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/string_util.cc View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
M base/string_util_unittest.cc View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
M net/base/net_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
12 years, 3 months ago (2008-09-25 19:19:26 UTC) #1
brettw
12 years, 3 months ago (2008-09-25 20:53:56 UTC) #2
Nice, LGTM.

Powered by Google App Engine
This is Rietveld 408576698