Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 4265002: Add proxies for ImageData and Graphics2D. These don't build by themselves, th... (Closed)

Created:
10 years, 1 month ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews
Visibility:
Public.

Description

Add proxies for ImageData and Graphics2D. These don't build by themselves, this is part of a larger patch. You can see most of the serialization mechanics already checked in to the same directory. TEST=none BUG=none Committed: http://code.google.com/p/ppapi/source/detail?r=65097

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -0 lines) Patch
A ppapi/proxy/ppb_graphics_2d_proxy.h View 1 chunk +62 lines, -0 lines 1 comment Download
A ppapi/proxy/ppb_graphics_2d_proxy.cc View 1 chunk +202 lines, -0 lines 1 comment Download
A ppapi/proxy/ppb_image_data_proxy.h View 1 chunk +50 lines, -0 lines 1 comment Download
A ppapi/proxy/ppb_image_data_proxy.cc View 1 chunk +234 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
This is my first pass, there are still some TODOs and this will only work ...
10 years, 1 month ago (2010-11-03 03:30:26 UTC) #1
piman
10 years, 1 month ago (2010-11-03 22:53:48 UTC) #2
Ok, I spent some time looking at the proxying code that's already there, but I'd
need more time to be 100% confident with everything.
It all seems to make sense, it's mostly boilerplate here, so LGTM with nits.

http://codereview.chromium.org/4265002/diff/1/2
File ppapi/proxy/ppb_graphics_2d_proxy.cc (right):

http://codereview.chromium.org/4265002/diff/1/2#newcode7
ppapi/proxy/ppb_graphics_2d_proxy.cc:7: #include <string.h>  // For memcpy
// For memset ?

http://codereview.chromium.org/4265002/diff/1/3
File ppapi/proxy/ppb_graphics_2d_proxy.h (right):

http://codereview.chromium.org/4265002/diff/1/3#newcode29
ppapi/proxy/ppb_graphics_2d_proxy.h:29: return reinterpret_cast<const
PPB_Graphics2D*>(target_interface());
static_cast should work when casting from void*

http://codereview.chromium.org/4265002/diff/1/5
File ppapi/proxy/ppb_image_data_proxy.h (right):

http://codereview.chromium.org/4265002/diff/1/5#newcode26
ppapi/proxy/ppb_image_data_proxy.h:26: return reinterpret_cast<const
PPB_ImageData*>(target_interface());
static_cast should work when casting from void*

Powered by Google App Engine
This is Rietveld 408576698