Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 42650: Update Linux gyp build to import and propagate external environment... (Closed)

Created:
11 years, 9 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update Linux gyp build to import and propagate external environment variables ($CC, $DISTCC_DIR, $HOME, etc.). Accomodate spelling change ($CHROME_SRC_DIR => $SRC_DIR) that makes the gyp SCons a little more generic. Use the new $LIB_DIR variable the gyp SCons generator now defines for us. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/SConscript.main View 2 chunks +2 lines, -0 lines 0 comments Download
M build/common.gypi View 2 chunks +16 lines, -2 lines 0 comments Download
M site_scons/site_tools/chromium_builders.py View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
11 years, 9 months ago (2009-03-26 18:15:24 UTC) #1
Mark Mentovai
11 years, 9 months ago (2009-03-26 18:18:00 UTC) #2
Fantastic.

http://www.lge.com/

Powered by Google App Engine
This is Rietveld 408576698