Issue 4263001: Code cleanup: comments, docstrings, and gpylint fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4263001: Code cleanup: comments, docstrings, and gpylint fixes. (Closed)

Created:
10 years, 1 month ago by diandersAtChromium

Modified:
9 years, 6 months ago

Reviewers:
davidjames

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Code cleanup: comments, docstrings, and gpylint fixes. Most of this is from this code review: http://codereview.chromium.org/4175007/diff/1/2 I also ran the code through gpylint and fixed some of the stuff, like making quoting consistent. Change-Id: Icb3896dbd4e975c7ea4687d58efd6372adfcc3c9 BUG=chromium-os:8205 TEST=Ran ./cros_changelog 0.7.48.0 and saw error; also ran ./cros_changelog 0.9.98.3 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ec5d7f0

Patch Set 1 #

Total comments: 1

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -19 lines)			Patch
	M	chromite/bin/cros_changelog	View		11 chunks	+65 lines, -19 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

diandersAtChromium

David, We don't have to push this now if you don't want to, but I ...

10 years, 1 month ago (2010-11-01 23:37:18 UTC) #1

diandersAtChromium

David, Should I abandon this, or do you want to look it over? ...just let ...

10 years, 1 month ago (2010-11-08 22:25:18 UTC) #2

davidjames

10 years, 1 month ago (2010-11-08 22:32:49 UTC) #3

Thanks very much. LGTM.

Sorry for the delay.

http://codereview.chromium.org/4263001/diff/1/2
File chromite/bin/cros_changelog (right):

http://codereview.chromium.org/4263001/diff/1/2#newcode203
chromite/bin/cros_changelog:203: # Sort the issues and return...
Only one period is needed here...

Expand Messages | Collapse Messages